Implement LevelHistograms as a struct #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
approved these changes
Jul 26, 2024
Comment on lines
+219
to
+220
| self.repetition_level_histogram.as_mut().map(LevelHistogram::reset); | ||
| self.definition_level_histogram.as_mut().map(LevelHistogram::reset); |
There was a problem hiding this comment.
So much nicer than what I was doing 😮
if let Some(hist) = self.repetition_level_histogram.as_mut() {
hist.reset()
}There was a problem hiding this comment.
I think your way is pretty nice too -- this is borderline too functional for my taste, but it seemed to be ok :)
Comment on lines
+279
to
+280
| if let (Some(page_hist), Some(chunk_hist)) = (page_histogram, chunk_histogram) { | ||
| chunk_hist.add(page_hist); |
There was a problem hiding this comment.
I thought I tried this and it didn't work. Thanks. My approach was to have add take an Option<LevelHistogram>.
| /// Length will be `max_level + 1`. | ||
| /// | ||
| /// Returns `None` when `max_level == 0` (because histograms are not necessary in this case) | ||
| pub fn try_new(max_level: i16) -> Option<Self> { |
There was a problem hiding this comment.
I struggled with this name, as the consensus seemed to be that try_new returns a Result. I wound up opting for maybe_new, but I prefer this!
There was a problem hiding this comment.
Yeah maybe there is a better convention but I think this is pretty standard in my experience
Comment on lines
+652
to
+662
| impl From<Vec<i64>> for LevelHistogram { | ||
| fn from(inner: Vec<i64>) -> Self { | ||
| Self { inner } | ||
| } | ||
| } | ||
|
|
||
| impl From<LevelHistogram> for Vec<i64> { | ||
| fn from(value: LevelHistogram) -> Self { | ||
| value.into_inner() | ||
| } | ||
| } |
Comment on lines
+897
to
+898
| let repetition_level_histogram = repetition_level_histogram.map(LevelHistogram::from); | ||
| let definition_level_histogram = definition_level_histogram.map(LevelHistogram::from); |
etseidl
pushed a commit
that referenced
this pull request
Jul 31, 2024
Add test for metadata equivalence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets apache#6105
Per the suggestion on apache#6105 (review) I tried out encapsulating the information about level histograms in a rust struct,
LevelHistogramI think I like this as it encapsulates the
Vec<i64>for histograms, so that the operations on it can be named and documented