Modify /compiler-info to show both active and inactive compilers #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,3 +124,85 @@ describe("getAllBuildStatuses", () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("getAllCompilerInfo", () => { | |||
This also keeps the tests I made, but I removed the part that involved inactive compilers
azu-b
force-pushed
the
abarraza_WEBPLAT-4418_modify-kevin-compiler-info
branch
from
34f7ae0 to
057bb4e
Compare
azu-b
commented
Mar 27, 2022
mq2thez
approved these changes
Mar 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
We need an endpoint that returns all the compilers, both active and inactive. Before this change, endpoints only show active compilers.
What is the change?
It adds the inactive compilers and their
not builtstatus to the compilers list returned by the/compiler-infoendpoint.Testing
Run
yarn testand make sure all tests pass.Questions and additional information for Reviewer
First time contributing to Kevin 👀