Add a start and stop compiler endpoints #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates an endpoint that accepts POST requests with the name of a compiler that will be stopped.
As with the /stop-compiler endpoint, this accepts a POST request
Kevin has a maximum of compilers that can be active, so with this change the endpoint will not start anything if the maximum has been reached.
mpmartinez-etsy
approved these changes
Apr 22, 2022
azu-b
deleted the
abarraza_WEBPLAT-4421_start-and-stop-compiler-endpoints
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It adds two new endpoints:
/start-compilerandstop-compiler. They can be used to manually start and stop a specific compiler.Context / Why are we making this change?
These endpoints will give users more control of the things they have compiled.
Testing and QA Plan
abarraza_WEBPLAT-4421_start-and-stop-compiler-endpointsyarnpkg linkImpact
This change adds new functionality to Kevin. It doesn't affect what existed before these commits.