Merge pull request #1019 from staticssleever668/fix/song_insert_excep…

…tion Fix warnings in SongCacheIndex
etternagame · Aug 2, 2021 · 50703b1 · 50703b1
2 parents e1b2451 + 9f321fd
commit 50703b1
Show file tree

Hide file tree

Showing 4 changed files with 67 additions and 72 deletions.
diff --git a/src/Etterna/Models/Misc/DBProfile.cpp b/src/Etterna/Models/Misc/DBProfile.cpp
@@ -34,7 +34,7 @@ DBProfile::LoadDBFromDir(std::string dir)
 		// Open a database file
 		db = new SQLite::Database(FILEMAN->ResolvePath(dir) + PROFILE_DB,
 								  SQLite::OPEN_READWRITE);
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedNoProfile;
 	}
 	try {
@@ -46,7 +46,7 @@ DBProfile::LoadDBFromDir(std::string dir)
 		LoadScoreGoals(db);
 		LoadPlayLists(db);
 		LoadPlayerScores(db);
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedTampered;
 	}
 	delete db;
@@ -469,7 +469,7 @@ DBProfile::SaveDBToDir(string dir,
 		// Open a database file
 		db = new SQLite::Database(filename,
 								  SQLite::OPEN_READWRITE | SQLite::OPEN_CREATE);
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedNoProfile;
 	}
 	try {
@@ -516,7 +516,7 @@ DBProfile::SaveDBToDir(string dir,
 		db->exec("CREATE INDEX IF NOT EXISTS idx_songs "
 				 "ON songs(song, pack, id)");
 		transaction.commit();
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedTampered;
 	}
 	delete db;
@@ -1001,7 +1001,7 @@ DBProfile::SavePlayerScores(SQLite::Database* db,
 										insertOffset.exec();
 									}
 								}
-							} catch (std::exception) { // No replay data for
+							} catch (std::exception&) { // No replay data for
 													   // this score }
 								hs->UnloadReplayData();
 							}
@@ -1125,7 +1125,7 @@ DBProfile::WriteReplayData(const HighScore* hs)
 		// Open a database file
 		db = new SQLite::Database(filename,
 								  SQLite::OPEN_READWRITE | SQLite::OPEN_CREATE);
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedNoProfile;
 	}
 	try {
@@ -1146,7 +1146,7 @@ DBProfile::WriteReplayData(const HighScore* hs)
 			insertOffset.exec();
 		}
 		transaction.commit();
-	} catch (std::exception) {
+	} catch (std::exception&) {
 		return ProfileLoadResult_FailedTampered != 0;
 	}
 	delete db;