Skip to content

Commit

Permalink
we don't actually care about topscore when uploading, in fact it's bad
Browse files Browse the repository at this point in the history
we're already using get all pb ptrs, and if we do this ma scores will never be synced
  • Loading branch information
MinaciousGrace committed May 19, 2020
1 parent 4373b26 commit d41847a
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions src/Etterna/Singletons/DownloadManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1160,11 +1160,6 @@ DownloadManager::UploadScores()
vector<HighScore*> toUpload;
for (auto& vec : scores) {
for (auto& scorePtr : vec) {
auto ts = scorePtr->GetTopScore();

// rescoring should already have properly set topscore values
// if they were to have shuffled due to the rescore
if (ts == 1 || ts == 2) {
// handle rescores, ignore upload check
if (newly_rescored.count(scorePtr))
toUpload.push_back(scorePtr);
Expand Down Expand Up @@ -1205,12 +1200,10 @@ DownloadManager::ForceUploadScoresForChart(const std::string& ck, bool startnow)
auto& test = cs->GetAllScores();
for (auto& s : test)
if (!s->forceuploadedthissession) {
auto ts = s->GetTopScore();
if (ts == 1 || ts == 2) {
if (s->GetGrade() != Grade_Failed) {
if (s->GetGrade() != Grade_Failed &&
!s->IsUploadedToServer(wife3_rescore_upload_flag)) {
this->ScoreUploadSequentialQueue.push_back(s);
this->sequentialScoreUploadTotalWorkload += 1;
}
}
}
}
Expand Down

0 comments on commit d41847a

Please sign in to comment.