Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual delay affected by rates #485

Closed
Durvin opened this issue Mar 21, 2019 · 2 comments
Closed

Visual delay affected by rates #485

Durvin opened this issue Mar 21, 2019 · 2 comments

Comments

@Durvin
Copy link

Durvin commented Mar 21, 2019

Describe the bug
Whenever i enter a song with a rate different than 1.0x, my visual delay gets affected. Via testing i've found it to act as if the visual delay is divided by the rate.

To Reproduce
Steps to reproduce the behavior:

  1. Increase visual delay with F3 to a "large" number (my standard was 0.060)
  2. Enter a song and watch the mean ms offset.
  3. Increase the rate by atleast 1.3x
  4. Notice how the mean ms offset is far more negative

Expected behavior
Visual delay does not get affected by rates

Screenshots
2019-02-09_135227

Desktop (please complete the following information):

  • Etterna version 0.64.0
  • no notes for a fix from neither 0.65 nor 0.65.1
@nico-abram
Copy link
Member

I think we might be able to easily and hackily fix the visual delay changing with rate thing multipliying by rate in

m_fMusicSecondsVisible = fPositionSeconds - g_fVisualDelaySeconds.Get();

nico-abram added a commit that referenced this issue May 19, 2019
MinaciousGrace added a commit that referenced this issue May 21, 2019
* Fix #485

* format
@MinaciousGrace
Copy link
Contributor

349efa1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants