Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Unix: escape the URL passed to xdg-open #1018

Merged

Conversation

staticssleever668
Copy link
Contributor

@staticssleever668 staticssleever668 commented Jul 31, 2021

This fixes some shell errors, for example when there is an apostrophe (sh: 1: Syntax error: Unterminated quoted string.) or a parenthesis (sh: 1: Syntax error: "(" unexpected) in the URL.

@staticssleever668 staticssleever668 marked this pull request as draft July 31, 2021 22:36
This fixes some shell errors, for example when there is an apostrophe
(`sh: 1: Syntax error: Unterminated quoted string.`) or a parenthesis
(`sh: 1: Syntax error: "(" unexpected`) in the URL.
@staticssleever668 staticssleever668 marked this pull request as ready for review July 31, 2021 23:45
@jameskr97 jameskr97 self-assigned this Aug 1, 2021
@jameskr97
Copy link
Member

👍

@poco0317 poco0317 merged commit e1b2451 into etternagame:develop Aug 2, 2021
@staticssleever668 staticssleever668 deleted the fix/escape_xdg_open branch August 2, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants