⌛C++20 Upgrade #1071
Merged
⌛C++20 Upgrade #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskr97
force-pushed
the
feature/cpp20
branch
2 times, most recently
from
1ea19bd to
8e27817
Compare
git-subtree-dir: extern/rapidjson git-subtree-split: 4d6cb08189cf7336821f04090b612baa2ca6a90d
jameskr97
force-pushed
the
feature/cpp20
branch
from
8e27817 to
c856f0a
Compare
|
Can we remove extern/fmt and use std::fmt if we're using C++20? |
|
I tested this locally and it built fine with VS2022 and playing a song worked fine. Like you said on discord, it doesn't seem to be necessary to merge this after glfw. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to C++20
Must be merged after glfw
It's time for an upgrade. The only requirement changed is that we must use at minimum:
Active Developers: Please test locally to ensure you can still compile.