Make Highest-Only mode work correctly in filters #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, highest-only mode would allow songs that had a particular skillset as the highest in any of its charts to be included, even if the chart that did so did not meet other filter criteria. This commit changes the IsSkillsetHighestOfAnySteps function into a new IsSkillsetHighestOfChart function, which takes in a Steps* as a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, highest-only mode would allow songs that had a particular skillset
as the highest in any of its charts to be included, even if the chart
that did so did not meet other filter criteria.
This commit changes the IsSkillsetHighestOfAnySteps function into a new
IsSkillsetHighestOfChart function, which takes in a Steps* as a parameter.