Fix overriding ktorHttpClientFactory #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vkanellopoulos
commented
Jul 15, 2024
vkanellopoulos
commented
- fix overriding ktorHttpClientFactory in EudiWallet object for openId4Vci and openId4Vp
- also, fix not deleting deferred documents when deferred issuing fails
vkanellopoulos
force-pushed
the
fix/ktor_client_factory
branch
from
9dc119d
to
f5cafdf
Compare
…Vci and openId4Vp; fix don't delete deferred documents if deferred issuing fails
vkanellopoulos
force-pushed
the
fix/ktor_client_factory
branch
from
f5cafdf
to
e0805be
Compare
marinaioannou
approved these changes
Jul 15, 2024
vkanellopoulos
merged commit 16a4d98
into
eu-digital-identity-wallet:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.