Feat: Add capture for windows signals #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euamcg
force-pushed
the
add_windows_signals
branch
3 times, most recently
from
8ca7469
to
da250a5
Compare
Adds code to capture windows signals in the runtime. Includes tests for starting and killing the runtime, also includes a change so github actions will build a windows container.
euamcg
force-pushed
the
add_windows_signals
branch
from
da250a5
to
e4624b7
Compare
| .arg("ping") | ||
| .assert() | ||
| .failure() | ||
| .stderr(predicate::str::contains("No connection could be made")); |
There was a problem hiding this comment.
are the only diffs here predicates? Can't we make one test and or these?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code to capture windows signals in the runtime. Includes tests for starting and killing the runtime, also includes a change so github actions will build a windows container.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Link to issue
Please add a link to any relevant issues/tickets.
Type of change
Please delete options that are not relevant.
Test plan (required)
Demonstrate the code is solid. Which commands did you test with and what are the expected results?
Which tests have you added or updated? Do the tests cover all of the changes included in this PR?
Screenshots/Screencaps
Please add previews of any UI Changes.