-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Excel look and feel and column specified table filtering #76
Conversation
1. Capability to turn on/off sorting 2. Capability to turn on/off filtering for columns Pending: Showing menu on filter icon click
1. Added column icons preferences for filtering 2. Added support to control the right click for filtering 3. When right click is turned off, then clicking on filtering icon only should bring the popup 4. Sorting on/off control
…nderer will be used to render all columns 2. A Enum is introduced to configure the filter style for fitering columns. Be default, 'DEFAULT' style rendered and all the filtering/filtered icons are not used in default style.
1. Updated to display respective column names while searching multiple columns, and Added default filtering and filtered icons 2. Removed clear table icon in popup window
<groupId>org.oxbow</groupId> | ||
<artifactId>swing-bits</artifactId> | ||
<version>1.0.0-SNAPSHOT</version> | ||
<groupId>org.oxbow.se</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group and artifact name should not change
<groupId>org.oxbow</groupId> | ||
<artifactId>swing-bits</artifactId> | ||
<version>1.0.0-SNAPSHOT</version> | ||
<groupId>org.oxbow.se</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group and artifact name should not change
@@ -23,7 +23,7 @@ | |||
<repositories> | |||
<repository> | |||
<id>oxbow-repository</id> | |||
<url>https://github.com/eugener/oxbow/raw/master/maven/repository</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the ref to the original repo
@@ -1,13 +1,13 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<metadata> | |||
<groupId>org.oxbow</groupId> | |||
<artifactId>swing-bits</artifactId> | |||
<groupId>org.oxbow.se</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
group and artifact name should not change
return clearAllFilters(); | ||
} | ||
}); | ||
//removed clear filter for JTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, we should not just remove it, but have API to enable/disable it with default being disabled
|
||
TableCellRenderer headerRenderer = null; | ||
switch (filterType) { | ||
case DEFAULT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice - users should be able to choose the renderer
Thank you for a very nice PR! |
1. user can enable or disable clear filter in search pop-up window as their requirement 2. rolled back snapshot version
c7d0776
to
cac555d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Thank you for accepting changes to merge. I have a request to do from your side. Can we deploy the latest changes to maven repository. So, everyone directly use the jar. |
I will try to make it happen within the next week. |
The Please let me know if you have any issues. |
Thank you so much! I have no issues. |
Updated table filtering in such a way that the user feels the Excel type filtering.
In previous scenarios of table filtering, we needed to right-click on the column header to view the search pop-up window. Now we added an icon in the column header for filtering options, and by just clicking on the icon, it shows the search pop-up window.
And introducing specific column searching along with table searching (search option available for all columns in the table).
To differentiate filtered columns as part of Excel filtering, introduced two different icons for before and after filtering and also provided the privilege to the user to change the icons as per their needs.
Not as a disadvantage, to more like excel feel removed clear table option in search pop-up window.