Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow defining shared memory size at runtime #282

Closed
Officeyutong opened this issue Apr 15, 2024 · 4 comments · Fixed by #285
Closed

[FEATURE] Allow defining shared memory size at runtime #282

Officeyutong opened this issue Apr 15, 2024 · 4 comments · Fixed by #285
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Officeyutong
Copy link
Contributor

Currently the size of shared memory is hard coded in bpftime_shm_internal.hpp and is set to 20MB

This might be too small for some cases. Allow setting that size at runtime using an environment variable

@Officeyutong Officeyutong added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2024
@NobinPegasus
Copy link
Contributor

Should the size be passed as flag?
or we should use environment variable and set it's value using export before invoking the tool?

@Officeyutong
Copy link
Contributor Author

Should the size be passed as flag?

or we should use environment variable and set it's value using export before invoking the tool?

Use flags to set environment variables

@NobinPegasus
Copy link
Contributor

Can you provide some more guidelines on which files should I make the changes.
And if I am not wrong, we would be able to invoke bpftime like this if implemented correctly. sudo ~/.bpftime/bpftime SHARED_MEMORY=100
Right?

@Officeyutong
Copy link
Contributor Author

Can you provide some more guidelines on which files should I make the changes. And if I am not wrong, we would be able to invoke bpftime like this if implemented correctly. sudo ~/.bpftime/bpftime SHARED_MEMORY=100 Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants