Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] fix polling and runtime values #85

Merged
merged 3 commits into from
Mar 15, 2023
Merged

[runtime] fix polling and runtime values #85

merged 3 commits into from
Mar 15, 2023

Conversation

yunwei37
Copy link
Member

Description

Fix the return value and polling error in cpp example. Make the return value more clear.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #85 (d347918) into main (3b07511) will increase coverage by 0.78%.
The diff coverage is 92.15%.

❗ Current head d347918 differs from pull request most recent head 6a439c7. Consider uploading reports for the commit 6a439c7 to get more accurate results

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   79.04%   79.82%   +0.78%     
==========================================
  Files          12       14       +2     
  Lines        1188     1264      +76     
==========================================
+ Hits          939     1009      +70     
- Misses        249      255       +6     
Impacted Files Coverage Δ
runtime/wasm-bpf-rs/src/pipe.rs 34.18% <31.57%> (-3.43%) ⬇️
runtime/wasm-bpf-rs/src/handle.rs 93.75% <93.75%> (ø)
runtime/wasm-bpf-rs/src/lib.rs 83.87% <95.00%> (-4.47%) ⬇️
runtime/wasm-bpf-rs/src/runner.rs 100.00% <100.00%> (ø)
runtime/wasm-bpf-rs/src/state.rs 96.25% <100.00%> (+0.70%) ⬆️
runtime/wasm-bpf-rs/src/tests/mod.rs 99.21% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yunwei37 yunwei37 merged commit 2748c96 into main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants