Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Github Action to ignore markdown files (#193) #194

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Optimize Github Action to ignore markdown files (#193) #194

merged 1 commit into from
Aug 22, 2022

Conversation

zion830
Copy link
Contributor

@zion830 zion830 commented Aug 21, 2022

I solved the issue #193

@yeonns yeonns requested review from designe and yeonns August 21, 2022 14:34
yeonns
yeonns approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@yeonns yeonns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zion830
WIth paths-ignore, euphony's build action will be executed only when logic has been changed!
Thank you for contribution! 👍

@nodobi
Copy link
Contributor

nodobi commented Aug 22, 2022

LGTM 👍

designe
designe approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@designe designe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zion830
This patch is very useful because there is no need for additional build checks following markdown modifications.

Let me accept & merge with master ;)

@designe designe linked an issue Aug 22, 2022 that may be closed by this pull request
Optimize Github Action #193
Closed
@designe designe added the Clean Code Make some pretty & beautiful clean code label Aug 22, 2022
@designe designe merged commit 58c7b82 into euphony-io:master Aug 22, 2022
zion830 added a commit to zion830/euphony that referenced this pull request Sep 1, 2022
@zion830
Optimize Github Action to ignore markdown files (euphony-io#193) (eup…
05217bb 
…hony-io#194)
@designe designe added the osca-22 Contribution From Open Source Academy 2022 label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonns yeonns yeonns approved these changes

@designe designe designe approved these changes

Assignees

@zion830 zion830

Labels
Clean Code Make some pretty & beautiful clean code osca-22 Contribution From Open Source Academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize Github Action
4 participants
@zion830 @nodobi @designe @yeonns