MET-5806 sonarcloud recomendations part III

europeana · Aug 7, 2024 · f8bc46a · f8bc46a
1 parent 5631f87
commit f8bc46a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/...s-media-service/src/main/java/eu/europeana/metis/mediaprocessing/RdfDeserializerImpl.java b/...s-media-service/src/main/java/eu/europeana/metis/mediaprocessing/RdfDeserializerImpl.java
@@ -43,9 +43,13 @@
  */
 class RdfDeserializerImpl implements RdfDeserializer {
 
+  @SuppressWarnings("java:S1075")
   private static final String XPATH_OBJECT = "/rdf:RDF/ore:Aggregation/edm:object/@rdf:resource";
+  @SuppressWarnings("java:S1075")
   private static final String XPATH_IS_SHOWN_BY = "/rdf:RDF/ore:Aggregation/edm:isShownBy/@rdf:resource";
+  @SuppressWarnings("java:S1075")
   private static final String XPATH_HAS_VIEW = "/rdf:RDF/ore:Aggregation/edm:hasView/@rdf:resource";
+  @SuppressWarnings("java:S1075")
   private static final String XPATH_IS_SHOWN_AT = "/rdf:RDF/ore:Aggregation/edm:isShownAt/@rdf:resource";
   private static final String OEMBED_NAMESPACE = "https://oembed.com/";
   private static final String XPATH_HAS_SERVICE =

diff --git a/...rvice/src/main/java/eu/europeana/metis/mediaprocessing/extraction/MediaExtractorImpl.java b/...rvice/src/main/java/eu/europeana/metis/mediaprocessing/extraction/MediaExtractorImpl.java
@@ -75,14 +75,6 @@ enum ProcessingMode {FULL, REDUCED, NONE}
     this.oEmbedProcessor = (OEmbedProcessor) getMediaProcessor(mediaProcessorList, OEmbedProcessor.class);
   }
 
-  private <T> Object getMediaProcessor(List<?> mediaProcessorList, Class<T> type) {
-    for (Object mediaProcessor : mediaProcessorList) {
-      if (type.isInstance(mediaProcessor)) {
-        return type.cast(mediaProcessor);
-      }
-    }
-    return null;
-  }
   /**
    * Constructor for non-testing purposes.
    *
@@ -114,6 +106,15 @@ public MediaExtractorImpl(int redirectCount, int thumbnailGenerateTimeout,
     this.oEmbedProcessor = new OEmbedProcessor();
   }
 
+  private <T> Object getMediaProcessor(List<?> mediaProcessorList, Class<T> type) {
+    for (Object mediaProcessor : mediaProcessorList) {
+      if (type.isInstance(mediaProcessor)) {
+        return type.cast(mediaProcessor);
+      }
+    }
+    return null;
+  }
+
   @Override
   public ResourceExtractionResult performMediaExtraction(RdfResourceEntry resourceEntry,
       boolean mainThumbnailAvailable) throws MediaExtractionException {