Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added property to set transition name on the overlay #296

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Added property to set transition name on the overlay #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92cb693
Added property to set transition name on the overlay
pietromanneschi Aug 23, 2018
1558b7b
Readme Fixed
pietromanneschi Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ There is also a ssr build with css file extracted. Take a look in /dist folder.
| reset | false | Boolean | false | Resets position and size before showing modal |
| clickToClose | false | Boolean | true | If set to `false`, it will not be possible to close modal by clicking on the background |
| transition| false | String | | Transition name |
| overlayTransition| false | String | 'overlay-fade'| Transition name for the background overlay |
| classes | false | [String, Array] | 'v--modal'| Classes that will be applied to the actual modal box, if not specified, the default 'vue--modal' class will be applied |
| width | false | [String, Number] | 600 | Width in pixels or percents (e.g. 50 or "50px", "50%") |
| height | false | [String, Number] | 300 | Height in pixels or percents (e.g. 50 or "50px", "50%") or `"auto"` |
Expand Down
6 changes: 5 additions & 1 deletion src/Modal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<transition name="overlay-fade">
<transition :name="overlayTransition">
<div v-if="visibility.overlay"
ref="overlay"
:class="overlayClass"
Expand Down Expand Up @@ -64,6 +64,10 @@ export default {
type: Boolean,
default: false
},
overlayTransition: {
type: String,
default: 'overlay-fade'
},
transition: {
type: String
},
Expand Down