Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish .babelrc file #49

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Don't publish .babelrc file #49

merged 1 commit into from
Jan 23, 2018

Conversation

mawangod
Copy link
Contributor

More and more npm packages contain ES2015+ code.
As discussed in this AMA, this causes a lot of troubles (Uglify and old browsers) for people.

One possible solution is to transpile external dependencies, as discussed in this issue on create-react-app and implemented in this pull request.

This doesn't currently work with vue-js-toggle-button as the .babelrc file is published on npm.

By adding the .babelrc file to .npmignore, the bug would go away once a new version of vue-js-toggle-button is published.

see: source 1 and source 2

@euvl
Copy link
Owner

euvl commented Jan 23, 2018

Hey thanks for such a detailed explanation! 👍 👍 👍
Will have to do the same for my other plugins 😄

Thanks

@euvl euvl merged commit 7367375 into euvl:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants