Removing state that ties a ChargePoint instance to a specific connected CP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-garrett-ev-energy
requested review from
thm35,
alexmclarty and
danielconnaughtonevenergy
alexmclarty
approved these changes
Feb 28, 2024
| from abc import abstractmethod | ||
|
|
||
|
|
||
| class AsyncMessageHandler(ABC): |
There was a problem hiding this comment.
Everyone loves their interfaces now! 😄
There was a problem hiding this comment.
Go does not get the credit there I'm afraid ;)
|
Looking at the changes here I think we could potentially make a subclass of |
|
@ben-garrett-ev-energy please close this |
|
Agree @thm35, solid. 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to use the message parsing/creation and the @on annotations of the ocpp library, but we don't want to have ChargePoint objects tied to a specific connection - we want them to be stateless and able to handle messages for any connected CPs in a parallel architecture.