Add Travis CI config #28
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| sudo: false | ||
|
|
||
| os: | ||
| - osx | ||
| - linux | ||
|
|
||
| language: node_js | ||
| node_js: lts/* | ||
|
|
||
| before_install: | ||
| - if [ $TRAVIS_OS_NAME == "linux" ]; then | ||
|
There was a problem hiding this comment. We probably don't need any of this. We don't use any native modules, so I doubt need X either. There was a problem hiding this comment. These were for running tests, which we aren't doing. |
||
| export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0; | ||
| sh -e /etc/init.d/xvfb start; | ||
| sleep 3; | ||
| fi | ||
|
|
||
| install: | ||
| - npm install | ||
|
There was a problem hiding this comment. This needs to be There was a problem hiding this comment. The point of optional dependencies is that they are optional... i.e., you don't need to specify that flag. |
||
|
|
||
| script: | ||
| - npm run vscode:prepublish | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just building on Linux should be enough. We don't have anything platform dependent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"I don't expect anything to break on other platforms" is not the same as "building on other platforms is a detriment". We get it for no additional cost, so I don't see a reason to remove macOS builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is responsible to use "free" resources when you don't really need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't "really need" CI builds as a whole, or GitHub collaboration, or any of the other services we use. We've decided to adopt them because they provide benefit to us and our project. The case of building on other platforms is no different. That most of our code isn't special-cased for certain platforms certainly doesn't mean that it won't have platform-specific problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are really wearing me out will all this debate about things that are really not that important in the whole scheme of things (e.g. life, the universe, and everything).
This is a really small project and I haven't felt a need for CI at all. But if you really feel it would be helpful, we can set up travis to do a quick build check on Linux. That is my offer. End of discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the debates over relatively small things are a result of the frequent criticism on subjects that are even less consequential. It's things like this that make someone resistant to productive discussion over points that are legitimately relevant. If you make it seem like you're needlessly criticizing someone else's work (whether or not you think it's with good reason), when you have a disagreement over something meaningful neither side is going to be interested in compromise. This is something I've heard voiced by multiple career managers: if you want to produce the best result both for users and your team, you must let the little debates slide so you can push back when you have a strong opinion on a meaningful topic. In the same way that you may think that continuous integration isn't important, I don't think that spaces after
ifs or the type of quote I use is. Digging in on one side will inevitably be met with an equal reaction from the other, even if it isn't immediate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit that I am totally guilty of exactly what I am complaining about many times over. And if I have offended because of this, I am sorry. Part of me would like to say more about the specifics of why so many nit picks and what I really meant (certainly not criticism) since that seems to have rubbed you the wrong way, but it seems hypocritical at this point.
So, please keep up the good work and I will do my best to be more mindful of how I come across in reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and to do a better job making it clear what is important to me and what is no big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I will certainly try as best as I can from here forward to be receptive to the larger asks and evaluate whether/how there may be a solution that keeps both of us happy so we don't get into binary debates like this. On the topic of formatting and style, I haven't intentionally gone against the format you've laid out but at the same time I haven't spent much of any effort to adhere to it; I'll take a closer look at my code to make sure that I follow that so we aren't leaving ourselves with unspoken issues of that sort.
As for this PR, I'll take a look tomorrow and get it finished up; I plan to remove the macOS builds and keep it to just Linux until we find a need for other platforms. I believe that the OS differences could become significant for us in the future, but as you said it's a value judgment and right now it seems like the simple solution is enough for the vast majority of cases.