finish test

Makefile

@@ -20,7 +20,8 @@ test: ## Run tests
 .PHONY: test-coverage
 test-coverage: ## Run tests with coverage
 	flutter test --coverage
-	genhtml coverage/lcov.info -o coverage/html
+	@genhtml coverage/lcov.info -o coverage/html
+	@open coverage/html/index.html
 
 ##@ Build
 .PHONY: bump

assets/l10n/en/menu.yaml

@@ -99,7 +99,7 @@ ingredient:
       repeat: Product already has the same ingredient, cannot select repeatedly.
   amount:
     label: Amount Used
-    helper: |
+    helper: |-
       Default amount used.
       If customers are able to adjust the amount,
       set different quantities in "Quantity."

assets/l10n/en/order_attribute.yaml

@@ -35,10 +35,10 @@ mode:
   - name
   helper:
   - statOnly: Normal setting, selecting won't affect the order price.
-    changePrice: |
+    changePrice: |-
       Selecting this setting may affect the order price.
       For example: Takeout +$30, Eco Cup -$5.
-    changeDiscount: |
+    changeDiscount: |-
       Selecting this setting will affect the total price based on the discount.
       For example: Dine-in +10% service charge, Friends & Family Discount -10%.
   - Explanation of customer setting categories

assets/l10n/en/transit.yaml

@@ -282,8 +282,8 @@ GS:
       empty: Cannot be Empty
       invalid: |-
         Invalid text. It must include:
-        /spreadsheets/d/<ID>/
-        Or provide the ID directly (combination of letters, numbers, underscores, and hyphens).
+        • /spreadsheets/d/<ID>/
+        • Or provide the ID directly (combination of letters, numbers, underscores, and hyphens).
     createSheet: Unable to Create Sheet in Spreadsheet
     createSheetHelper: |-
       Don't worry, it's usually easy to solve!

assets/l10n/zh/global.yaml

@@ -10,7 +10,7 @@ totalCount:
 searchCount: 搜尋到 {count} 個結果
 dialog:
   deletionTitle: 刪除確認通知
-  deletionContent: |
+  deletionContent: |-
     確定要刪除「{name}」嗎？
 
     {more}此動作將無法復原！

assets/l10n/zh/order_attribute.yaml

@@ -27,10 +27,10 @@ mode:
     changeDiscount: 折扣
   helper:
   - statOnly: 一般的設定，選取時並不會影響點單價格。
-    changePrice: |
+    changePrice: |-
       選取設定時，可能會影響價格。
       例如：外送 + 30塊錢、環保杯 - 5塊錢。
-    changeDiscount: |
+    changeDiscount: |-
       選取設定時，會根據折扣影響總價。
       例如：內用 + 10% 服務費、親友價 - 10%。
 name:

assets/l10n/zh/transit.yaml

@@ -237,8 +237,8 @@ GS:
       empty: 不能為空
       invalid: |-
         不合法的文字，必須包含：
-        /spreadsheets/d/<ID>/
-        或者直接給 ID（英文+數字+底線+減號的組合）
+        • /spreadsheets/d/<ID>/
+        • 或者直接給 ID（英文+數字+底線+減號的組合）
     createSheet: 無法在試算表中建立表單
     createSheetHelper: |-
       別擔心，通常都可以簡單解決！

lib/components/style/route_circular_button.dart

@@ -10,8 +10,6 @@ class RouteCircularButton extends StatelessWidget {
 
   final String? route;
 
-  final Map<String, String> routePathParameters;
-
   final bool popTrueShowSuccess;
 
   final VoidCallback? onTap;
@@ -21,7 +19,6 @@ class RouteCircularButton extends StatelessWidget {
     required this.text,
     required this.icon,
     this.route,
-    this.routePathParameters = const <String, String>{},
     this.popTrueShowSuccess = false,
     this.onTap,
   });
@@ -42,10 +39,7 @@ class RouteCircularButton extends StatelessWidget {
             ),
             onPressed: onTap ??
                 () async {
-                  final result = await context.pushNamed(
-                    route!,
-                    pathParameters: routePathParameters,
-                  );
+                  final result = await context.pushNamed(route!);
                   if (result == true) {
                     if (context.mounted) {
                       showSnackBar(context, S.actSuccess);

lib/helpers/util.dart

@@ -46,7 +46,7 @@ class Util {
         return Center(child: Text(error.toString()));
       }
 
-      if (!snapshot.hasData) {
+      if (snapshot.connectionState == ConnectionState.waiting) {
         return const Center(
           child: SizedBox(
             height: 20,

lib/ui/analysis/analysis_view.dart

@@ -67,8 +67,7 @@ class _AnalysisViewState extends State<AnalysisView> with AutomaticKeepAliveClie
                   message: S.analysisChartTutorialContent,
                   child: RouteCircularButton(
                     key: const Key('anal.add_chart'),
-                    route: Routes.chartModal,
-                    routePathParameters: const {'id': '_'},
+                    route: Routes.chartNew,
                     icon: KIcons.add,
                     text: S.analysisChartTitleCreate,
                   ),

test/helpers/util_test.dart

@@ -1,5 +1,6 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:intl/date_symbol_data_local.dart';
 import 'package:possystem/helpers/util.dart';
 
 void main() {
@@ -32,6 +33,13 @@ void main() {
       expect(date.second, equals(33));
     });
 
+    test('#formatCompact', () {
+      initializeDateFormatting('en', null);
+      DateTimeRange range = Util.getDateRange(now: DateTime.utc(2021, 6, 14), days: 3);
+
+      expect(range.formatCompact('en'), equals('20210614 - 20210616'));
+    });
+
     testWidgets('#handleSnapshot error', (WidgetTester tester) async {
       final f = Util.handleSnapshot((context, data) => const SizedBox.shrink());
       const err = AsyncSnapshot<String>.withError(ConnectionState.done, 'test');

test/ui/analysis/widgets/history_order_list_test.dart

@@ -12,6 +12,7 @@ import 'package:possystem/models/repository/seller.dart';
 import 'package:possystem/routes.dart';
 import 'package:possystem/translator.dart';
 import 'package:possystem/ui/analysis/widgets/history_order_list.dart';
+import 'package:possystem/ui/analysis/widgets/history_order_modal.dart';
 
 import '../../../mocks/mock_cache.dart';
 import '../../../mocks/mock_database.dart';
@@ -194,6 +195,15 @@ void main() {
       verify(txn.delete(any, where: anyNamed('where'))).called(4);
     });
 
+    testWidgets('order not found', (tester) async {
+      when(database.query(any, where: argThat(equals('id = 666'), named: 'where'))).thenAnswer((_) => Future.value([]));
+
+      await tester.pumpWidget(const MaterialApp(home: HistoryOrderModal(666)));
+      await tester.pumpAndSettle();
+
+      expect(find.text(S.analysisHistoryOrderNotFound), findsOneWidget);
+    });
+
     setUpAll(() {
       initializeCache();
       initializeTranslator();

test/ui/menu/menu_page_test.dart

@@ -17,6 +17,7 @@ import 'package:possystem/translator.dart';
 import 'package:possystem/ui/menu/menu_page.dart';
 import 'package:provider/provider.dart';
 
+import '../../mocks/mock_cache.dart';
 import '../../mocks/mock_storage.dart';
 import '../../test_helpers/file_mocker.dart';
 import '../../test_helpers/translator.dart';
@@ -335,8 +336,14 @@ void main() {
       expect(find.byKey(const Key('catalog.c-1')), findsOneWidget);
     });
 
+    setUp(() async {
+      await cache.reset();
+      when(cache.get(any)).thenReturn(true);
+    });
+
     setUpAll(() {
       initializeStorage();
+      initializeCache();
       initializeTranslator();
       initializeFileSystem();
     });

test/ui/order/order_page_test.dart

@@ -316,6 +316,12 @@ void main() {
           ['p-1', '2'],
           ['p-2', '2'],
         ], 36);
+
+        // open by tapping snapshot product
+        await tester.tap(find.byKey(const Key('cart_snapshot.0')));
+        await tester.pumpAndSettle();
+
+        expect(find.byKey(const Key('order.ingredient.pi-2')), findsOneWidget);
       });
     });
 

test/ui/transit/google_sheet/select_spreadsheet_test.dart

@@ -73,7 +73,7 @@ void main() {
           )));
     }
 
-    testWidgets('exporter pick invalid and exist', (tester) async {
+    testWidgets('exporter pick invalid and exit', (tester) async {
       when(cache.get(eCacheKey)).thenReturn('old-id:true:old-name');
 
       await tester.pumpWidget(buildApp());
@@ -84,10 +84,13 @@ void main() {
       expect(editorW.controller?.text, equals('old-id'));
 
       await tester.enterText(editor, 'QQ');
+      await tester.tap(find.byKey(const Key('text_dialog.confirm')));
+      await tester.pump();
+      // not in dialog
+      expect(find.text(S.transitGSErrorSpreadsheetIdInvalid), findsOneWidget);
+
       await tester.tap(find.byKey(const Key('text_dialog.cancel')));
       await tester.pumpAndSettle();
-      // not in dialog
-      expect(find.byKey(const Key('text_dialog.cancel')), findsNothing);
     });
 
     testWidgets('exporter pick not exist', (tester) async {
@@ -217,4 +220,18 @@ void main() {
       initializeAuth();
     });
   });
+
+  test('GoogleSheetProperties hash code', () {
+    final a = GoogleSheetProperties(1, 'title');
+    final b = GoogleSheetProperties(1, 'title');
+    final c = GoogleSheetProperties(1, 'title2');
+    final d = GoogleSheetProperties(2, 'title');
+
+    expect(a, equals(b));
+    expect(a.hashCode, equals(b.hashCode));
+    expect(a, isNot(equals(c)));
+    expect(a.hashCode, isNot(equals(c.hashCode)));
+    expect(a, isNot(equals(d)));
+    expect(a.hashCode, isNot(equals(d.hashCode)));
+  });
 }