DateTimeConfigurationChangeNotification moved to v8::Isolate (#6)

Co-authored-by: Prabhakar Patil <PrabhakarRPatil@eaton.com>
evanlucas · Mar 8, 2021 · 73a04f5 · 73a04f5
1 parent c2bf66f
commit 73a04f5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -7,12 +7,12 @@
     "test": "tap test.js --cov"
   },
   "dependencies": {
-    "bindings": "~1.2.1",
-    "nan": "~2.3.3"
+    "bindings": "^1.2.1",
+    "nan": "^2.3.3"
   },
   "devDependencies": {
-    "node-gyp": "~3.0.3",
-    "tap": "~2.1.0"
+    "node-gyp": "^3.0.3",
+    "tap": "^14.11.0"
   },
   "license": "MIT",
   "author": "Evan Lucas <evanlucas@me.com>",

diff --git a/src/binding.cc b/src/binding.cc
@@ -18,7 +18,7 @@ NAN_METHOD(Reset) {
 #else
   tzset();
 #endif
-  Date::DateTimeConfigurationChangeNotification(isolate);
+  isolate->DateTimeConfigurationChangeNotification(Isolate::TimeZoneDetection::kRedetect);
 }
 
 NAN_MODULE_INIT(Init) {

diff --git a/test.js b/test.js
@@ -13,7 +13,7 @@ test('should be able to reset the timezone', function(t) {
   reset()
 
   var d2 = new Date('10/20/2015 8:50:00 AM UTC')
-  t.equal(d2.toString(), 'Mon Oct 19 2015 22:50:00 GMT-1000 (HST)')
+  t.equal(d2.toString(), 'Mon Oct 19 2015 22:50:00 GMT-1000 (Hawaii-Aleutian Standard Time)')
 
   delete process.env.TZ