Skip to content

Commit

Permalink
Allow empty zip files. Require a line break at the end.
Browse files Browse the repository at this point in the history
An empty zip file is completely valid, but the current mod_zip syntax
does not support them. This comes up in cases where e.g. a user clicks
"Download this folder" - and the backend needs to special-case empty folders
and use different code to generate an empty .zip file.

This is technically a breaking change - though the documentation does not
say anything about trailing line breaks, and it seems unlikely that
anyone would actually rely on the last line break being optional.
  • Loading branch information
dimaryaz committed Dec 20, 2022
1 parent 3540d1e commit e7966b9
Show file tree
Hide file tree
Showing 2 changed files with 117 additions and 137 deletions.
Loading

0 comments on commit e7966b9

Please sign in to comment.