-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer passing headers to subrequests #107
Comments
False positive bug report, this behaviour now needs to be explicitly defined as specified in #87 Closing. |
Re-opening, it seems the fix in #87 is not completely comprehensive. I'm using a custom nginx module to process cookies, that looks for |
…le rather than upstream/fastcgi Tests generated in the process of exploring issue evanmiller#107, no functional changes but verifying that headers_in.cookies are not broken by zeroing the headers_in structure.
After commit eb3f28c
It looks like we're zeroing the headers_in before sending subrequests. This is a change in behaviour from the previous version where headers (including cookies) got passed to subrequests.
It seems debatable which behaviour is optimal. I could see some applications wanting clean headers going through to a subrequest, while others may want cookies and other headers passed through. Going to do a bit more testing on this.
The text was updated successfully, but these errors were encountered: