Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer passing headers to subrequests #107

Closed
anthonyryan1 opened this issue Apr 6, 2023 · 2 comments
Closed

No longer passing headers to subrequests #107

anthonyryan1 opened this issue Apr 6, 2023 · 2 comments

Comments

@anthonyryan1
Copy link
Collaborator

anthonyryan1 commented Apr 6, 2023 •
edited

After commit eb3f28c

It looks like we're zeroing the headers_in before sending subrequests. This is a change in behaviour from the previous version where headers (including cookies) got passed to subrequests.

It seems debatable which behaviour is optimal. I could see some applications wanting clean headers going through to a subrequest, while others may want cookies and other headers passed through. Going to do a bit more testing on this.
@anthonyryan1
Copy link
Collaborator Author

False positive bug report, this behaviour now needs to be explicitly defined as specified in #87

Closing.

@anthonyryan1
Copy link
Collaborator Author

Re-opening, it seems the fix in #87 is not completely comprehensive.

I'm using a custom nginx module to process cookies, that looks for &r->headers_in.cookies. We're setting the header, but not re-populating the cookies structure. If I'm not mistaken this will also break the built in $cookie_* variables and the userid_filter module.

@anthonyryan1 anthonyryan1 reopened this Apr 6, 2023
anthonyryan1 added a commit to anthonyryan1/mod_zip that referenced this issue Apr 9, 2023
@anthonyryan1
Unit tests for Cookie passing to subrequests when using an nginx modu…
a63f78c 
…le rather than upstream/fastcgi

Tests generated in the process of exploring issue evanmiller#107, no functional changes
but verifying that headers_in.cookies are not broken by zeroing the headers_in
structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonyryan1