Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mod_zip compatible with nginx 1.23.0+ #93

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Make mod_zip compatible with nginx 1.23.0+ #93

merged 1 commit into from
Jun 25, 2022

Conversation

d--j
Copy link
Contributor

@d--j d--j commented Jun 24, 2022

This PR makes mod_zip (also) compatible with nginx 1.23.0+.

The two necessary changes were:

  • r->headers_out.cache_control is now a linked list
  • ngx_http_variable_unknown_header now needs the request as first parameter

Fixes #92

@d--j
Make mod_zip compatible with nginx 1.23.0+
cdc1874 
nginx 1.23 changed the way known multi value headers are handled (as linked lists)
@evanmiller
Copy link
Owner

Thanks! Reading the code comment we can probably get rid of all that Cache-Control stuff (RIP IE) but this looks fine to me.

@evanmiller evanmiller merged commit 5b2604b into evanmiller:master Jun 25, 2022
@d--j d--j deleted the ngx123 branch June 25, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mod_zip does not compile with nginx 1.23.0+
2 participants
@d--j @evanmiller