Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty zip files. Require a line break at the end. #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow empty zip files. Require a line break at the end. #99

wants to merge 1 commit into from

Commits on Dec 20, 2022

  1. Allow empty zip files. Require a line break at the end. 

    An empty zip file is completely valid, but the current mod_zip syntax
does not support them. This comes up in cases where e.g. a user clicks
"Download this folder" - and the backend needs to special-case empty folders
and use different code to generate an empty .zip file.

This is technically a breaking change - though the documentation does not
say anything about trailing line breaks, and it seems unlikely that
anyone would actually rely on the last line break being optional.
    @dimaryaz
    dimaryaz committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    e7966b9 View commit details
    Browse the repository at this point in the history