Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading 4.10.0 failed for semantic import versioning is required #145

Closed
pacoxu opened this issue Jun 3, 2021 · 6 comments
Closed

upgrading 4.10.0 failed for semantic import versioning is required #145

pacoxu opened this issue Jun 3, 2021 · 6 comments

Comments

@pacoxu
Copy link

pacoxu commented Jun 3, 2021

go mod download github.com/evanphx/json-patch@v4.10.0

go mod download: github.com/evanphx/json-patch@v4.10.0+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required

No go.mod file in https://github.com/evanphx/json-patch/tree/v4.9.0
But there is a go.mod in https://github.com/evanphx/json-patch/tree/v4.10.0

@liggitt
Copy link
Contributor

liggitt commented Jun 3, 2021

correct... only the v5 subfolder can contain a go.mod file

@BenTheElder
Copy link
Contributor

see previously: #98

@evanphx
Copy link
Owner

evanphx commented Jun 4, 2021

Ack, I added go.mod stuff back in January to sort out CI stuff accidentally. I'll sort this out now.

@evanphx
Copy link
Owner

evanphx commented Jun 4, 2021

Ok, I've cleaned it up and published 4.11.0.

@BenTheElder
Copy link
Contributor

Thanks!

@pacoxu
Copy link
Author

pacoxu commented Jun 4, 2021

It works.

Thank you all.

@pacoxu pacoxu closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants