-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid v > 1 go module #98
Comments
Sorry to let this sit for so long. Please feel free to submit a PR to change to |
@BenTheElder what you say? |
Hi @evanphx thanks for the response :-) No worries, I'll get on drafting a PR :-) |
filed #100, but there are some outstanding questions there about how we want to handle it (e.g. travis needs to use at least one more recent go version, which ones?). |
Thanks @BenTheElder for getting this sorted out! |
Since this is tagged as v4.X and has a go.mod, the import path must be
github.com/evanphx/json-patch/v4
including in themodule
directive and in any code importing packages across the repo and externally.https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher
Trying to import v4.6.0 from a project using go modules does not work without this, v4.5.0+incompatible is the last version that works with go modules (this works because it is "incompatible" but not opted into modules by not having a go.mod).
Removing go.mod / go.sum would also work, v4.7.0 could be imported as +incompatible with no other changes.
I'm not sure which route you'd prefer, but currently projects using go modules are stuck on
v4.5.0
. I'd be happy to send a PR for whatever option is acceptable.The text was updated successfully, but these errors were encountered: