Revert "Conform to RFC6902 replacement semantics" for v4.x #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2663031. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This reverts commit c235ce8. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This reverts commit caa7f26. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This reverts commit a5df74a. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
cc @liggitt |
|
agree. keeping 4.x compatible makes it much more reasonable to pick up bugfixes. |
|
a v4.8.0 release that includes this and #108 would resolve outstanding support issues on Kubernetes release branches |
|
This has been merged in and a v4.8.0 tagged, as @liggitt requested. |
|
Thank you! <3 |
|
yes, thanks |
|
thanks a ton @thaJeztah and @evanphx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to containerd/cri#1551 (comment)
Pull request #85 introduced a potentially breaking change, and (see the discussion on kubernetes/kubernetes#91622 (comment)) resulted in Kubernetes to hold-back this change in their dependencies. Given that this change can be considered a breaking change, it should probably have warranted a major version bump (to stick with SemVer).
Now that this project has a v5.x release, it should be possible to revert the change for v4.x. Consumers of this package that want to opt-on to the breaking change can update their dependency to use the v5 module, and consumers that are not (yet) ready to opt-in can continue using the v4.x releases until they are.
If this pull request is accepted, I would like to request a v4.8.0 patch release to be tagged with this change, to allow kubernetes to use a tagged version in its dependencies, and to prevent (other) consumers from "accidentally" opting in.
Thanks in advance for considering!
@evanphx PTAL
/cc @liggitt @dims (who are more familiar with the changes, and could possibly provide more input if needed 🤗)