Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if raw is a null pointer for findObject #173

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Check if raw is a null pointer for findObject #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion patch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ func findObject(pd *container, path string) (container, string) {

next, ok := doc.get(decodePatchKey(part))

if next == nil || ok != nil {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that it would be better to correct this variable name from ok to err, and fix https://github.com/evanphx/json-patch/blob/master/patch.go#L395 to return an error if the key doesn't exist.

A test case demonstrating how to produce this condition would be good?

if next == nil || ok != nil || next.raw == nil {
return nil, ""
}

Expand Down