Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to RFC6902 replacement semantics #85

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Conform to RFC6902 replacement semantics #85

merged 4 commits into from
Dec 20, 2019

Commits on Nov 4, 2019

  1. Conform to RFC6902 replacement semantics. 

    A "replace" patch operation referencing a key that does not exist in the
target object are currently being accepted; ultimately becoming "add"
operations on the target object. This is incorrect per the
specification:

From https://tools.ietf.org/html/rfc6902#section-4.3 section about
"replace":

    The target location MUST exist for the operation to be successful.

This corrects the behavior by returning an error in this situation.
    @brettbuddin
    brettbuddin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    a5df74a View commit details
    Browse the repository at this point in the history

  2. Test for copying non-existent key.

    @brettbuddin
    brettbuddin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    caa7f26 View commit details
    Browse the repository at this point in the history

  3. Test for testing non-existent and null-value keys.

    @brettbuddin
    brettbuddin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c235ce8 View commit details
    Browse the repository at this point in the history

  4. Test for copying null-value key.

    @brettbuddin
    brettbuddin committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    2663031 View commit details
    Browse the repository at this point in the history