Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license identifier to project metadata #601

Closed
wants to merge 1 commit into from

Conversation

mschoettle
Copy link

License scanning tools (such as the one used by GitLab) rely on the project metadata (made available via the PyPi API) to detect the license for a package.

Currently, license: null is returned.

This PR adds the license to the project metadata.

@adamchainz
Copy link
Collaborator

The project already follows the packaging standard:

If you are using a standard, well-known license, it is not necessary to use this field. Instead, you should use one of the classifiers starting with License ::. (As a general rule, it is a good idea to use a standard, well-known license, both to avoid confusion and because some organizations avoid software whose license is unapproved.)

No license field is required, since the classifier is specified.

I think the GitLab scanner needs updating to read classifiers instead.

@mschoettle
Copy link
Author

Fair enough. Unfortunately, the classifiers are ambiguous in some cases, although not for MIT (see pypa/trove-classifiers#17). And PyPI for some reason does not use the classifier to return the license in its API: https://pypi.org/pypi/whitenoise/json

In any case, PEP 639 aims to improve on this and it has been provisionally accepted. It makes sense to wait until PyPI and build tools added support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants