fix(deno): close all subprocess resources #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the custom test runner to the built in Deno one. Tests in a single module are now run in series, but if more tests are added they can be split across files and the upcoming `--jobs` arg can be used for parallization.
This commit fixes lib/deno/mod.ts to close all subprocess resources on cleanup, so stdout and stdin, not just the child process itself. This commit also changes `esbuild.stop` and `esbuild.initalize` to be callable multiple times in the same isolate.
evanw
reviewed
May 6, 2021
| console.error(`❌ deno tests failed`) | ||
| Deno.exit(1) | ||
| } else { | ||
| console.log(`✅ deno tests passed`) |
There was a problem hiding this comment.
I had this in there because I run all tests in parallel and without this it's hard to see which top-level test failed. That's ok though; I can add this back.
|
Thanks for contributing this! I appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is split into three independent commits with comments for easy reviewing :-)