Add NetBSD amd64 binary

[gdt]

This is labeled amd64 in descriptive text rather than "64-bit" because
NetBSD supports a number of 64-bit CPU types, and NetBSD people will
be looking for "amd64" which is our word for that CPU and machine
type. Otherwise, this is cut and paste from the FreeBSD x86_64
support.

[gdt]

I am a go and esbuild newbie, and am here because I need this for zwavejs. I ran into a test issue that I think it is unrelated, so this hasn't been tested as well as it normally should be. esbuild does build and run fine on NetBSD amd64.

[evanw]

I'm not sure this will work because netbsd is not currently listed as a platform that node can return. From https://nodejs.org/api/process.html#process_process_platform:

The process.platform property returns a string identifying the operating system platform on which the Node.js process is running.

Currently possible values are:

• 'aix'
• 'darwin'
• 'freebsd'
• 'linux'
• 'openbsd'
• 'sunos'
• 'win32'

The value 'android' may also be returned if the Node.js is built on the Android operating system. However, Android support in Node.js is experimental.

This matters because esbuild's API uses process.platform to determine which package to take the binary executable from:

esbuild/lib/npm/node-platform.ts

Line 35 in b806837

let platformKey = `${process.platform} ${os.arch()} ${os.endianness()}`;

This key is used to look up into the map of known packages here:

esbuild/lib/npm/node-platform.ts

Lines 10 to 30 in b806837

	export const knownWindowsPackages: Record<string, string> = {
	'win32 arm64 LE': 'esbuild-windows-arm64',
	'win32 ia32 LE': 'esbuild-windows-32',
	'win32 x64 LE': 'esbuild-windows-64',
	};
	export const knownUnixlikePackages: Record<string, string> = {
	'android arm64 LE': 'esbuild-android-arm64',
	'darwin arm64 LE': 'esbuild-darwin-arm64',
	'darwin x64 LE': 'esbuild-darwin-64',
	'freebsd arm64 LE': 'esbuild-freebsd-arm64',
	'freebsd x64 LE': 'esbuild-freebsd-64',
	'openbsd x64 LE': 'esbuild-openbsd-64',
	'linux arm LE': 'esbuild-linux-arm',
	'linux arm64 LE': 'esbuild-linux-arm64',
	'linux ia32 LE': 'esbuild-linux-32',
	'linux mips64el LE': 'esbuild-linux-mips64le',
	'linux ppc64 LE': 'esbuild-linux-ppc64le',
	'linux x64 LE': 'esbuild-linux-64',
	'sunos x64 LE': 'esbuild-sunos-64',
	};

If process.platform can't return netbsd then running esbuild's JavaScript API on NetBSD won't work. You are welcome to build esbuild from source from NetBSD because Go supports NetBSD, but I don't think it makes sense to publish a NetBSD binary executable to npm if node doesn't support NetBSD.

[gdt]

Thank you for taking the time to review and the useful comments. I will look into that with the NetBSD node people; we do have node in pkgsrc and people use it, so there could be some changes that ought to be upstreamed but haven't been.

If it's excess cognitive load and you want to close the PR, and have me reopen if I figure out how to resolve all of this, that's totally fine with me.

[gdt]

On node as built from pkgsrc on NetBSD, I ran the js snippet from the doc you linked and got

This platform is netbsd

I can't find that we patch this in, but I also don't understand everything...

[gdt]

I am happy to rebase if someone with merge authority is willing to hit merge, or if it's otherwise helpful.

[evanw]

Would it be correct to say that the underlying problem is that the node docs are incorrect, and NetBSD is actually a platform supported by node? If so, we should file a bug report against node's documentation. But if not, it would be good for me to know that node on NetBSD is actually not supported.

[bsiegert]

The Net sad package collection has a node.js package but as far as I know, the NetBSD support is maintained as a patch outside of the upstream node.js tree. This means that officially, there is no NetBSD support in node, however in practice, there are a number of users on NetBSD. Evan Wallace ***@***.***> schrieb am Di., 12. Okt. 2021, 17:51:

…

Would it be correct to say that the underlying problem is that the node docs are incorrect, and NetBSD is actually a platform supported by node? If so, we should file a bug report against node's documentation. But if not, it would be good for me to know that node on NetBSD is actually not supported. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1624 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGTQGRZ4UWSDGVRTF7CHMTUGRKRFANCNFSM5ERLQ2HQ> .

[gdt]

Following up on what @bsiegert said, "supported" is a complicated word. In practice, anyone who wants to run node on NetBSD will use it via pkgsrc (at least 95%+ of them), and when installed that way, it worked for me. pkgsrc has patches for a vast number of things to deal with various portability issues, and while in theory people are supposed to file those upstream, there are always things that haven't been, because people don't get to it, or it turns out to be difficult, or something else.

I did review the patches in pkgsrc for node, and I didn't find any that I understood to change the platform list. But I can't conclude from that there aren't any because it's complicated and I don't fully understand.

I don't know if there's a requirement for esbuild for there to be offiicial support, or just that when people try to use it in the usual way it works. I can try to build node not under pkgsrc and see what happens.

[evanw]

Ok, I will move forward and start publishing the package with a note that node doesn't support NetBSD. Based on this conversation, it sounds like npm's install mechanism could potentially be patched such that installing a package with optionalDependencies works even with packages containing "os": ["netbsd"] despite that being an invalid value, so it's worth a try.

[gdt]

Thanks for taking the time to look at and merge my PR.

[evanw]

Version 0.13.6 of esbuild should theoretically have NetBSD support. Can someone on this thread try it out and let me know if it works or not?

[gdt]

The zwavejs hasn't updated to newer esbuild, but in an empty directory I did (well I found the binary in between):

npm install esbuild
./node_modules/esbuild/bin/esbuild --version

which printed 0.13.6, and then I did

$ file node_modules/esbuild/bin/esbuild 
node_modules/esbuild/bin/esbuild: ELF 64-bit LSB executable, x86-64, version 1 (NetBSD), statically linked, for NetBSD 7.0, Go BuildID=JClpsvE6vJWNRUkdVS5L/Ok0Z00V3xA0dw0JqvjrT/RorUL0O6DraPMxQnBsMZ/FjTBgTlQRL1Xo-4lXb7S, stripped

which looks fine.

So my not-very-node-clueful take is that all looks correct. Thanks!

[gdt]

And after editing yarn.lock in node-zwave-js, it resolves esbuild 0.13.6 ok. So I'm 98% sure all is well.