Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Zero Motorcycles #14823

Merged
merged 34 commits into from
Aug 3, 2024
Merged

Adding Zero Motorcycles #14823

merged 34 commits into from
Aug 3, 2024

Conversation

kscholty
Copy link
Contributor

@kscholty kscholty commented Jul 10, 2024

I added Zero Motorcycles to the list of supported vehicles.

Has been tested with real data now and works fine for me with and without VIN given for a 2023 DSR/X
I am not 100% sure about the time zone for the "FinishTime()" api.
As far as I could see it's local time. If you see problems with it, please let me know.

Have fun :-)

@kscholty kscholty marked this pull request as draft July 10, 2024 17:58
@andig andig added the devices Specific device support label Jul 11, 2024
Co-authored-by: Michael Geers <michael@geers.tv>
@github-actions github-actions bot added the stale Outdated and ready to close label Jul 18, 2024
@kscholty kscholty marked this pull request as ready for review July 20, 2024 11:11
@github-actions github-actions bot removed the stale Outdated and ready to close label Jul 25, 2024
@github-actions github-actions bot added the stale Outdated and ready to close label Aug 1, 2024
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/identity.go Outdated Show resolved Hide resolved
vehicle/zero/provider.go Outdated Show resolved Hide resolved
vehicle/zero/provider.go Show resolved Hide resolved
vehicle/zero/provider.go Outdated Show resolved Hide resolved
vehicle/zero/provider.go Outdated Show resolved Hide resolved
@andig
Copy link
Member

andig commented Aug 2, 2024

Danke für den PR! Ich hab ein paar Dinge gefunden, die sich deutlich einfacher machen lassen :)

@github-actions github-actions bot removed the stale Outdated and ready to close label Aug 2, 2024
@andig
Copy link
Member

andig commented Aug 3, 2024

Die identity kann weg. Was Du da implementiert hast ist genau die Vehicles() Funktion aus dem API- das kann analog wie bei den anderen Fahrzeugen gemacht werden (siehe Tesla).

@andig
Copy link
Member

andig commented Aug 3, 2024

Den Rest hab ich etwas vereinfacht ;)

@kscholty
Copy link
Contributor Author

kscholty commented Aug 3, 2024

Ok. Ändere ich.

vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
Simplification

Co-authored-by: andig <cpuidle@gmail.com>
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zero/provider.go Outdated Show resolved Hide resolved
kscholty and others added 2 commits August 3, 2024 12:33
Co-authored-by: andig <cpuidle@gmail.com>
Co-authored-by: andig <cpuidle@gmail.com>
vehicle/zero/api.go Outdated Show resolved Hide resolved
vehicle/zeromotorcycles.go Outdated Show resolved Hide resolved
@kscholty
Copy link
Contributor Author

kscholty commented Aug 3, 2024

Ich glaube, jetzt ist alles erledigt.

@andig
Copy link
Member

andig commented Aug 3, 2024

Stimmt die Zeit? Ich hätte erwartet, dass UTC im UTC Feld steht und hab das jetzt so geändert- könntest Du bitte nochmal prüfen? Dann rein damit.

@kscholty
Copy link
Contributor Author

kscholty commented Aug 3, 2024

Ich weiß ehrlich gesagt nicht genau, welche Zeit da steht. Ich vermute auch, es ist UTC.

Ich bekomme als Ergebnis CET, also UTC+1. Das sieht für mich erstmal nicht so falsch aus. Oder wird irgendwo noch Sommer/Winterzeit behandelt?

@kscholty
Copy link
Contributor Author

kscholty commented Aug 3, 2024

Also im UTC field steht etwas anderes. Die beiden Daten liegen Tage auseinander. Im actual field steht die Zeit des letzten Updates vermutlich auch in UTC. Habe daher wieder das actual field verwendet.

vehicle/zeromotorcycles.go Outdated Show resolved Hide resolved
@andig andig merged commit dc9f02b into evcc-io:master Aug 3, 2024
6 checks passed
@andig
Copy link
Member

andig commented Aug 3, 2024

Klasse PR, vielen Dank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants