Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push: Add "msg" as encoding #17368

Closed
wants to merge 1 commit into from
Closed

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Nov 20, 2024

"msg" is the default encoding anyway, but for consistency's sake, we should add it as a possible option for the encoding: configuration field.

@rhuss
Copy link
Contributor Author

rhuss commented Nov 20, 2024

I already documented this in evcc-io/docs#675. It felt unnatural to leave out a dedicated option for having the msg only and rely only on the default.

@andig
Copy link
Member

andig commented Nov 20, 2024

Even if documented, adding this diesn‘t do anything. Might as well leave out, docs are still correct.

@andig andig closed this Nov 20, 2024
@rhuss
Copy link
Contributor Author

rhuss commented Nov 21, 2024

"Does it hurt?" 😄

@andig From a UI perspective, it's still a difference if you have to leave something out to achieve a certain behaviour that you can't achieve otherwise. If you can specify "title" as an option, for me as a user, it is a surprise that there is no "msg", too, but that I have to rely on the default.

Aber egal, alles gut. Ich pendel mich schon noch ein :-)

rhuss added a commit to rhuss/evcc-docs that referenced this pull request Nov 21, 2024
@andig
Copy link
Member

andig commented Nov 21, 2024

From a UI perspective

UI hat hiermit nichts zu tun, bitte nicht immer alles in einen Topf werfen!

@andig
Copy link
Member

andig commented Nov 21, 2024

PS.: magst Du Dich mal bei info@evcc.io oder auf Slack melden?

@rhuss
Copy link
Contributor Author

rhuss commented Nov 21, 2024

Configfile schemata sind auch teil eines user interfaces (UI), oder taeusche ich mich da ? Genauso wie CLI optionen UI sind. Alles was mit dem "user" eine Schnittstelle hat ist UI, egal in welchen Rolle (admin oder enduser).

@andig
Copy link
Member

andig commented Nov 21, 2024

Configfile schemata sind auch teil eines user interfaces (UI), oder taeusche ich mich da ? Genauso wie CLI optionen UI sind

…und nichts davon passiert in diesem PR.

@rhuss
Copy link
Contributor Author

rhuss commented Nov 21, 2024

Sorry, my bad 🤦 . Da war ein Fehler im PR, ich meinte:

	case "msg":
		res = msg
	default:
		m.log.ERROR.Printf("Invalid enconding: %s (should be one of 'msg', 'title', 'json', 'csv' or 'tsv')", m.encoding)
		return

Ging neben der Symmetrie auch darum Typos ala jason oder, ganz beliebt :-), cvs, zu erkennen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants