-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push: Add "msg" as encoding #17368
Push: Add "msg" as encoding #17368
Conversation
I already documented this in evcc-io/docs#675. It felt unnatural to leave out a dedicated option for having the |
Even if documented, adding this diesn‘t do anything. Might as well leave out, docs are still correct. |
@andig From a UI perspective, it's still a difference if you have to leave something out to achieve a certain behaviour that you can't achieve otherwise. If you can specify "title" as an option, for me as a user, it is a surprise that there is no "msg", too, but that I have to rely on the default. Aber egal, alles gut. Ich pendel mich schon noch ein :-) |
UI hat hiermit nichts zu tun, bitte nicht immer alles in einen Topf werfen! |
PS.: magst Du Dich mal bei info@evcc.io oder auf Slack melden? |
Configfile schemata sind auch teil eines user interfaces (UI), oder taeusche ich mich da ? Genauso wie CLI optionen UI sind. Alles was mit dem "user" eine Schnittstelle hat ist UI, egal in welchen Rolle (admin oder enduser). |
…und nichts davon passiert in diesem PR. |
Sorry, my bad 🤦 . Da war ein Fehler im PR, ich meinte: case "msg":
res = msg
default:
m.log.ERROR.Printf("Invalid enconding: %s (should be one of 'msg', 'title', 'json', 'csv' or 'tsv')", m.encoding)
return Ging neben der Symmetrie auch darum Typos ala |
"msg" is the default encoding anyway, but for consistency's sake, we should add it as a possible option for the
encoding:
configuration field.