Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): back out commit 808b951c5a9eb5dd25adbd46a5887525d0a0913d #640

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

samueltardieu
Copy link
Collaborator

This backs out comit 808b951 "Remove optimization which gives worst benchmark results", as it severely degrades performances as shown in
#639.

This backs out comit 808b951
"Remove optimization which gives worst benchmark results", as it
severely degrades performances as shown in
<#639>.
@samueltardieu samueltardieu added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 54a6453 Jan 15, 2025
12 checks passed
@samueltardieu samueltardieu deleted the push-xvwtywvozruq branch January 15, 2025 12:04
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #640 will improve performances by 26.7%

Comparing push-xvwtywvozruq (1eb4c50) with main (fe5efe8)

Summary

⚡ 12 improvements
✅ 24 untouched benchmarks

Benchmarks breakdown

Benchmark main push-xvwtywvozruq Change
corner_to_corner_bfs 1.4 ms 1.2 ms +21.79%
corner_to_corner_dijkstra 1.8 ms 1.5 ms +16.33%
no_path_astar 2 ms 1.7 ms +18.68%
no_path_bfs 1.3 ms 1.1 ms +26.7%
no_path_dfs 1.3 ms 1.1 ms +26.69%
no_path_dijkstra 1.6 ms 1.4 ms +17.86%
no_path_fringe 1.9 ms 1.6 ms +19.56%
Compare kuhn_munkres with different input sizes[128] 2.9 ms 2.4 ms +21.74%
Compare kuhn_munkres with different input sizes[256] 19 ms 15.6 ms +21.25%
Compare kuhn_munkres with different input sizes[32] 86.6 µs 72.8 µs +19.05%
Compare kuhn_munkres with different input sizes[512] 575.1 ms 489.9 ms +17.38%
Compare kuhn_munkres with different input sizes[64] 448.3 µs 364.5 µs +22.99%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant