-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow mermaid visualization in domains #407
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Ok, I think is ready. I created new mermaid builder class just for domain case (if we want improve mermaid chart creation in future), leaving the same old logic for events and service. I improved graph test because previously they can failure for different spacing. Let me know if there are issues with my changes. |
Thank you for the pull request. V2 is coming out very soon, and things have changed under the hood. And now you can add mermaid code blocks to any resource. I'm going to close this for now. Ping if you want to keep open and push for a merge.... |
Motivation
Resolve issue #376 for create mermaid graph in domains.
Also I refactored graph.ts file introducing Mermaid builder class.
Hope everything is right, let me know if there are issues with my changes.
Have you read the Contributing Guidelines on pull requests?
Yes.