Query parameter time_filter ignored

[HughbertD]

Current Behavior

When making a request to: /users/me/orders/?time_filter=current_future via the SDK I am receiving all the orders back regardless of the time_filter used

Expected Behavior

I expect to receive only the current_future or past events depending on the parameter I provide

Possible Solution

Steps to Reproduce (for bugs)

Generate a token
Provide a request to: /users/me/orders/?time_filter=current_future
Observe the orders returned

Provide a request to: /users/me/orders/?time_filter=past
Observe the same orders are returned

I then used Insomnia (API client) to make the same request (same token etc) and observed properly filtered events returned depending on the query parameter provided.

Screenshots (if appropriate):

Your Environment

• SDK version: 1.0.3
• Node version: 8.11.4
• Browser name and version: Chrome
• Operating system: Mac OS, El Capitan

[benmvp]

Hi @HughbertD! 👋🏾

Thanks for your issue. Can you include two things for me?

1. Sample code for how you're making the request
2. A screenshot or other reproduction of the Network tab in your Chrome Developer Tools showing the request be made

This will help us figure out where the breakdown is happening.

[HughbertD]

Hi @benmvp

Thanks for taking a look!

Request is being made in node on the backend, so I can't show you a network tab.

const sdk = eventbrite.default({token: req.session.token});
  sdk.request('/users/me/orders/?time_filter=current_future').then(res => {
    console.log(res.orders.length);
    console.log(res.orders);
  }).catch(error => {
    console.log('ERROR:');
    console.log(error);
  });

Similar request in Insomnia that bears different (and correct) results
https://cl.ly/342dc6f0bd02

[kwelch]

I created a codesandbox that emulates the issue. I don't see why it would do that, but you can see from the sandbox that is does return 17 items, however when I use the API explorer it only returns 1.

Sandbox Result

API Explorer

UPDATE
I ran another test with a web based sandbox, and was able to get the network request. However, it has the params as I would have expected, but still returned all results.

[kwelch]

I debugged this locally with the API. The SDK defaults the Content-Type to application/json. Within the API parses that Content-Type tells it to ignore the query params and use the data or body of the request.

A workaround is to specifically set the method of the request to GET, which skips out defaulting. I have a sample react app that does this here.

I will also open a PR that will default method to GET.

I also threw it in Netlify, since it was easy and shouldn't have to build to test it.
https://youthful-raman-d8ec00.netlify.com/

[HughbertD]

Thanks @kwelch for looking into this, the work around is doing the trick for the time being :) 👍

[ebtravis]

🎉 This issue has been resolved in version 1.0.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀