Translate date when language change #7191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 13d56e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
adkif
requested changes
Nov 25, 2023
There was a problem hiding this comment.
@coderNadir The date picker seems to doesn't change language.
| @@ -59,14 +60,19 @@ export class AppComponent implements OnInit, AfterViewInit { | |||
| this.jitsuService.trackPageViews(); | |||
| this.seoService.trackCanonicalChanges(); | |||
|
|
|||
| // -- Translate date when language change | |||
| this.translate.onLangChange.subscribe( | |||
| (langChangeEvent: LangChangeEvent) => moment.locale(langChangeEvent.lang) | |||
There was a problem hiding this comment.
@coderNadir Investigate the origin of this warn message and eliminate it.
|
@rahul-rocket we can, @coderNadir will investigate and fix later all suggestions. |
|
@rahul-rocket yes you can merge it and I'll work on the requested changes later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Issue => #7175
Translate date when language change
Screenshots: