-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate date when language change #7191
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 13d56e5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderNadir The date picker seems to doesn't change language.
@@ -59,14 +60,19 @@ export class AppComponent implements OnInit, AfterViewInit { | |||
this.jitsuService.trackPageViews(); | |||
this.seoService.trackCanonicalChanges(); | |||
|
|||
// -- Translate date when language change | |||
this.translate.onLangChange.subscribe( | |||
(langChangeEvent: LangChangeEvent) => moment.locale(langChangeEvent.lang) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coderNadir Investigate the origin of this warn message and eliminate it.
@rahul-rocket we can, @coderNadir will investigate and fix later all suggestions. |
@rahul-rocket yes you can merge it and I'll work on the requested changes later |
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Issue => #7175
Translate date when language change
Screenshots: