Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Task Status Not Pre-filled During Edit, Causing Error on Save Without Re-selecting Status #8441

Merged
merged 5 commits into from
Oct 17, 2024
Merged

[Fix] Task Status Not Pre-filled During Edit, Causing Error on Save Without Re-selecting Status #8441

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
513683f
[Fix] Task Status Not Pre-filled During Edit, Causing Error on Save W…
samuelmbabhazi Oct 15, 2024
5f1d418
Merge branch 'develop' into fix/#8426-pre-filled-task-status
samuelmbabhazi Oct 15, 2024
0fc7dd2
Merge branch 'develop' into fix/#8426-pre-filled-task-status
samuelmbabhazi Oct 16, 2024
53799b1
fix: optimize "Task Status" selector usability
rahul-rocket Oct 17, 2024
d8af5c6
fix(cspell): typo spelling :-)
rahul-rocket Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/ui-core/shared/src/lib/tasks/task-status-select/task-status-select.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,16 @@ export class TaskStatusSelectComponent extends TranslationBaseComponent implemen
})
.pipe(
map(({ items, total }: IPagination<ITaskStatus>) => (total > 0 ? items : this._statuses)),
tap((statuses: ITaskStatus[]) => this.statuses$.next(statuses)),
tap((statuses: ITaskStatus[]) => {
this.statuses$.next(statuses);
if (!this.status) {
const defaultStatus = statuses.find((status) => status.name === TaskStatusEnum.OPEN);
if (defaultStatus) {
this.status = defaultStatus;
this.onChange(defaultStatus);
}
}
}),
untilDestroyed(this)
)
.subscribe();
Expand Down
Loading