Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Label Button Border in Dark Theme #3569

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

sv7000
Copy link
Contributor

@sv7000 sv7000 commented Feb 1, 2025

closes - #3568

Description

Fixed the border issue for the Label Button in Dark Theme. Ensured consistency with other buttons across the UI. Corrected the Kanban Board Label Button size as well in this PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Screenshot 2025-02-01 at 7 20 00 PM

Current screenshots

Screenshot 2025-02-01 at 7 32 57 PM

Summary by CodeRabbit

  • Style
    • Adjusted the border styling of task labels for a cleaner, more subtle appearance.
    • Increased the height of task labels in the Kanban interface for improved visual clarity and layout consistency.

Copy link
Contributor

coderabbitai bot commented Feb 1, 2025

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/lib/features/task/task-input-kanban.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

apps/web/lib/features/auth-user-task-input.tsx

Oops! Something went wrong! :(

ESLint: 8.46.0

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/apps/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Walkthrough

The pull request modifies the UI properties of the TaskLabels component in two places. In one file, the border color in the authentication user task input component is updated from #FFFFFF33 to #fff. In another, the height of the task labels in the Kanban task input is increased from h-7 to h-11. No changes have been made to the application logic or control flow.

Changes

Files Change Summary
apps/web/.../auth-user-task-input.tsx
apps/web/.../task/task-input-kanban.tsx
AuthUserTaskInput: Updated taskStatusClassName border color from #FFFFFF33 to #fff.
TaskInputKanban: Changed taskStatusClassName height from h-7 to h-11.

Possibly related PRs

Suggested labels

WEB, Bug fix, Improvement, UI/UX

Suggested reviewers

  • evereq
  • Cedric921

Poem

I'm a hopping rabbit in a code burrow so neat,
Tweaking labels with a twitch and a rhythmic beat.
Borders change color and heights now soar high,
A visual makeover that makes the interface fly.
Hop along and review—let's give these changes a try!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sv7000 sv7000 requested review from NdekoCode and evereq February 1, 2025 14:21
@sv7000 sv7000 self-assigned this Feb 1, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/lib/features/auth-user-task-input.tsx (1)

56-56: Consider applying consistent border styling across all components.

While this change fixes the Label Button border in dark theme, it creates a visual inconsistency with other similar components (Status, Properties, and Sizes dropdowns) that still use semi-transparent borders (#FFFFFF33).

For visual consistency, consider updating the border color to #fff for other components as well:

-taskStatusClassName="text-xs py-1.5 w-full dark:bg-[#1B1D22] dark:border dark:border-[#FFFFFF33] "
+taskStatusClassName="text-xs py-1.5 w-full dark:bg-[#1B1D22] dark:border dark:border-[#fff] "
-taskStatusClassName="w-full py-1.5 text-xs dark:bg-[#1B1D22] dark:border dark:border-[#FFFFFF33]"
+taskStatusClassName="w-full py-1.5 text-xs dark:bg-[#1B1D22] dark:border dark:border-[#fff]"
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5650129 and b592ecb.

📒 Files selected for processing (2)
  • apps/web/lib/features/auth-user-task-input.tsx (1 hunks)
  • apps/web/lib/features/task/task-input-kanban.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/web/lib/features/task/task-input-kanban.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: deploy

@NdekoCode NdekoCode requested a review from Cedric921 February 2, 2025 06:10
@NdekoCode NdekoCode added this to the v0.2.0 milestone Feb 2, 2025
@evereq evereq merged commit 58800a3 into develop Feb 2, 2025
13 checks passed
@evereq evereq deleted the Fix/label-tag-border branch February 2, 2025 06:30
@sv7000 sv7000 linked an issue Feb 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Label Tag Button Border Incorrect in Dark Theme
3 participants