wip: cleanup comments, choose higher cmake dep

everedero · Nov 11, 2023 · c98cc50 · c98cc50
1 parent afee43a
commit c98cc50
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/app/CMakeLists.txt b/app/CMakeLists.txt
@@ -4,7 +4,7 @@
 # Copyright (c) 2021 Nordic Semiconductor ASA
 # SPDX-License-Identifier: Apache-2.0
 
-cmake_minimum_required(VERSION 3.13.1)
+cmake_minimum_required(VERSION 3.20.0)
 # Use the project local board root folder
 set(BOARD_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/..")
 set(DTC_OVERLAY_FILE "${CMAKE_CURRENT_SOURCE_DIR}/../boards/nucleo_spi.overlay")

diff --git a/tests/driver/nrf24l01/CMakeLists.txt b/tests/driver/nrf24l01/CMakeLists.txt
@@ -1,8 +1,7 @@
 # Copyright (c) 2021, Legrand North America, LLC.
 # SPDX-License-Identifier: Apache-2.0
 
-#cmake_minimum_required(VERSION 3.20.0)
-cmake_minimum_required(VERSION 3.13.1)
+cmake_minimum_required(VERSION 3.20.0)
 # Use the project local board root folder
 set(BOARD_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/../../..")
 set(DTC_OVERLAY_FILE "${CMAKE_CURRENT_SOURCE_DIR}/../../../boards/nucleo_spi.overlay")

diff --git a/tests/driver/nrf24l01/src/main.c b/tests/driver/nrf24l01/src/main.c
@@ -29,7 +29,6 @@ LOG_MODULE_REGISTER(main, CONFIG_NRF24L01_LOG_LEVEL);
 ZTEST(nrf24l01, test_get_value)
 {
 	static const struct device *nrf24 = DEVICE_DT_GET(DT_NODELABEL(radio0));
-//zassert_equal(((struct nrf24l01_data *)(nrf24->data))->addr_width, 5, "address width is not 5");
 	zassert_equal(1, 1, "Dummy test fail");
     zassert_not_null(nrf24, "Device pointer is null");
     zassert_not_null(nrf24->name, "Device name is null");