Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix): only update table rows in update loop #28

Merged
merged 1 commit into from
Nov 15, 2023
Merged

(bugfix): only update table rows in update loop #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions pkg/charm/models/panels/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ import (
// Table is a tea.Model implementation
// that represents a table panel
type Table struct {
table tbl.Model
name string
mutex *sync.Mutex
rows map[types.UID]tbl.Row
columns []buoytypes.Column
err error
table tbl.Model
name string
mutex *sync.Mutex
rows map[types.UID]tbl.Row
columns []buoytypes.Column
err error
tempRows []tbl.Row
}

func NewTable(name string, table tbl.Model, columns []buoytypes.Column) *Table {
Expand All @@ -38,6 +39,12 @@ func (m *Table) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
case tea.WindowSizeMsg:
m.table.SetSize(msg.Width, msg.Height/2)
}

if len(m.tempRows) > 0 {
m.table.SetRows(m.tempRows)
m.tempRows = []tbl.Row{}
}

m.table, cmd = m.table.Update(msg)
return m, cmd
}
Expand Down Expand Up @@ -68,7 +75,7 @@ func (m *Table) updateRows() {
for _, row := range m.rows {
rows = append(rows, row)
}
m.table.SetRows(rows)
m.tempRows = rows
}

func (m *Table) Columns() []buoytypes.Column {
Expand Down