feat: implement the setting up of the scheme with managed contents #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
everettraven
reviewed
Jul 1, 2024
| // ApiVersion and Kind set. Failure to which the code will panic when adding the types to the scheme | ||
| scheme := runtime.NewScheme() | ||
| for _, obj := range objs { | ||
| gvk := obj.GetObjectKind().GetVersionKind() |
There was a problem hiding this comment.
Ref: https://pkg.go.dev/k8s.io/apimachinery/pkg/runtime/schema#ObjectKind
Suggested change
| gvk := obj.GetObjectKind().GetVersionKind() | |
| gvk := obj.GetObjectKind().GroupVersionKind() |
Applies to all other places the same error is popping up
everettraven
reviewed
Jul 1, 2024
everettraven
reviewed
Jul 1, 2024
everettraven
reviewed
Jul 1, 2024
| // if we continue to create a new cache every time, we should ensure that we are appropriately stopping | ||
| // the cache and configured sources _before_ replacing it in the mapping. | ||
| i.extensionCaches[ce.Name] = c | ||
| i.extensionCaches[ce.Name] = extensionsCacheData{ |
There was a problem hiding this comment.
Suggested change
| i.extensionCaches[ce.Name] = extensionsCacheData{ | |
| i.extensionCaches[ce.Name] = extensionCacheData{ |
everettraven
reviewed
Jul 1, 2024
| panic("Not implemented!") | ||
| if data, ok := i.extensionCaches[ce.GetName()]; ok { | ||
| data.Cancel() | ||
| delete(i.extensionCaches, ce.GetName) |
There was a problem hiding this comment.
Suggested change
| delete(i.extensionCaches, ce.GetName) | |
| delete(i.extensionCaches, ce.GetName()) |
everettraven
reviewed
Jul 1, 2024
| return &instance{ | ||
| rcm: rcm, | ||
| baseCfg: cfg, | ||
| extensionCaches: make(map[string]cache.Cache), | ||
| scheme: scheme, | ||
| extensionCaches: make(map[string]extensionCacheData{}), |
There was a problem hiding this comment.
Suggested change
| extensionCaches: make(map[string]extensionCacheData{}), | |
| extensionCaches: make(map[string]extensionCacheData), |
|
Going to ignore the lint failure for now. Will make sure this is addressed before creating a PR against the main repo |
everettraven
merged commit 90e32b2
into
feature/managed-content-cache
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist