Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Initial Uninstaller and MacOS BugFixes #49

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

Rev-G
Copy link
Contributor

@Rev-G Rev-G commented Nov 15, 2021

fixes for mac path and detection

Proposed Changes

Created initial uninstall for unix.
Fixed Mac OS detection for packageless binary install. Also fixed the .rc file Path (removed trailing /)

Type of Change

What kind of change to packageless is this?

  • Bug Fix
  • Feature
  • Documentation
  • Repository Enhancement
  • Testing

Checklist

Before the Pull Request can be considered for merging, the following Checklist should have the corresponding fields completed:

  • All tests have passed locally after running go test ./...
  • I have added tests that prove my fix or feature works as expected
  • I have added any necessary documentation for my fix or feature

Comments

Thank you for considering my change

fixes for mac path and detection
Copy link
Owner

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@everettraven everettraven merged commit de8f8a2 into everettraven:main Nov 15, 2021
@Rev-G Rev-G deleted the mac_installer_fix branch December 3, 2021 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants