Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Added test for args length to subcommand #53

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

kastolars
Copy link
Contributor

@kastolars kastolars commented Jan 26, 2022

Proposed Changes

Issue + comment: #51 (comment)

Type of Change

What kind of change to packageless is this?

  • Bug Fix
  • Feature
  • Documentation
  • Repository Enhancement
  • Testing

Checklist

Before the Pull Request can be considered for merging, the following Checklist should have the corresponding fields completed:

  • All tests have passed locally after running go test ./...
  • I have added tests that prove my fix or feature works as expected
  • I have added any necessary documentation for my fix or feature

Comments

Coverage for subcommand.go has reached 100%. I was able to get my test to succeed but not all of the other ones. Might need some guidance on what I can do to get them all to work. I develop on Windows at the moment, so that might be contributing to the problem here.

@kastolars kastolars changed the title Update subcommand_test.go Added test for args length to subcommand Jan 26, 2022
Copy link
Owner

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Thanks for your contribution @kastolars !

@everettraven
Copy link
Owner

@kastolars If you would like, you can open an issue regarding some tests failing when you run go test ./... and I will do my best to help get it sorted out. If you do, just make sure to provide the output from running go test ./....

@everettraven everettraven merged commit 24856bb into everettraven:main Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants