Skip to content
This repository has been archived by the owner on Mar 17, 2023. It is now read-only.

Added tests for empty volume paths #58

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

kastolars
Copy link
Contributor

@kastolars kastolars commented Jan 29, 2022

Proposed Changes

Issue + Comment: #51 (comment)

Type of Change

  • Bug Fix
  • Feature
  • Documentation
  • Repository Enhancement
  • Testing

Checklist

Before the Pull Request can be considered for merging, the following Checklist should have the corresponding fields completed:

  • All tests have passed locally after running go test ./...
  • I have added tests that prove my fix or feature works as expected
  • I have added any necessary documentation for my fix or feature

Comments

I had to come up with a MockUtility function to simulate a Getwd error because otherwise supplying an empty string for the path still succeeds.

This will push run_sc up to 98.4% coverage

Copy link
Owner

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @kastolars ! Thanks for the contribution! You've helped a ton with improving the test coverage!

@everettraven everettraven merged commit 449ef84 into everettraven:main Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants