Print Integer as expected type if String is given #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zgyorffi
force-pushed
the
fix_expected_type_message
branch
from
92f92a4 to
ac9542a
Compare
erosb
reviewed
Oct 18, 2020
| @@ -150,7 +150,7 @@ public boolean requiresInteger() { | |||
| return requiresInteger; | |||
| } | |||
|
|
|||
| public boolean isRequiresNumber() { | |||
| public boolean requiresNumber() { | |||
There was a problem hiding this comment.
Please don't rename public methods, it breaks API compatibility (I know that isRequiresNumber() is a very poor name :))
| import java.util.concurrent.atomic.AtomicLong; | ||
|
|
||
|
|
||
| public class TypeChecker { |
There was a problem hiding this comment.
Please make this class package-private.
erosb
pushed a commit
to erosb/hazelcast
that referenced
this pull request
Apr 4, 2021
….12.1 to 1.12.2 the error messages changed due to the following PRs: everit-org/json-schema#387 everit-org/json-schema#401
erosb
pushed a commit
to hazelcast/hazelcast
that referenced
this pull request
Apr 5, 2021
….12.1 to 1.12.2 the error messages changed due to the following PRs: everit-org/json-schema#387 everit-org/json-schema#401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #381