This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
deps: update dependencies to Kubernetes v1.26 #58
+272
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanposhiho
commented
Apr 24, 2023
| @@ -87,7 +87,7 @@ setup: | |||
| GOBIN=$(DEV_TOOL_PREFIX)/bin go install $(CODEGEN_PKG_NAME)/cmd/informer-gen@$(CODEGEN_PKG_VERSION) | |||
| GOBIN=$(DEV_TOOL_PREFIX)/bin go install $(CODEGEN_PKG_NAME)/cmd/deepcopy-gen@$(CODEGEN_PKG_VERSION) | |||
| GOBIN=$(DEV_TOOL_PREFIX)/bin go install sigs.k8s.io/kind@latest | |||
| GOBIN=$(DEV_TOOL_PREFIX)/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.50.1 | |||
| GOBIN=$(DEV_TOOL_PREFIX)/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2 | |||
There was a problem hiding this comment.
update to be the latest version. (1.50.X doesn't support golang v1.20)
sanposhiho
commented
Apr 24, 2023
| @@ -58,8 +57,6 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| rand.Seed(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
It's deprecated in v1.20.
The math/rand package now automatically seeds the global random number generator (used by top-level functions like Float64 and Int) with a random value
https://tip.golang.org/doc/go1.20#math/rand
sanposhiho
commented
Apr 24, 2023
| kubethrottler "github.com/everpeace/kube-throttler/pkg/scheduler_plugin" | ||
| "k8s.io/component-base/logs" | ||
| "k8s.io/kubernetes/cmd/kube-scheduler/app" | ||
| ) | ||
|
|
||
| func kubeSchedulerCmd() *cobra.Command { | ||
| rand.Seed(time.Now().UnixNano()) |
sanposhiho
commented
Apr 25, 2023
| @@ -1,4 +1,4 @@ | |||
| apiVersion: kubescheduler.config.k8s.io/v1beta2 | |||
There was a problem hiding this comment.
v1beta2 is already deprecated and will be removed soon:
kubernetes/kubernetes#117556
everpeace
approved these changes
Apr 25, 2023
.github/workflows/ci.yaml
Outdated
| @@ -21,6 +21,7 @@ jobs: | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version-file: 'go.mod' | |||
| go-version: "1.20" | |||
There was a problem hiding this comment.
go.mod now specifies 1.20. Do we need this? ditto for other places.
|
Thanks |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies to Kubernetes v1.26.
Also, it updates the Golang version to v1.20.